MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

x86: flag as bad AVX512 insns with EVEX.z set but EVEX.aaa clear

Browse Source 
This combination makes no sense and is documented to cause #UD.
This commit is contained in:
Jan Beulich 2021-03-25 08:19:21 +01:00
parent c0e54661f7
commit 5364285240
5 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gas/ChangeLog
View File

@ -1,3 +1,9 @@
2021-03-25 Jan Beulich <jbeulich@suse.com>
* testsuite/gas/i386/avx512f-nondef.s: Add case for EVEX.z
without mask register.
* testsuite/gas/i386/avx512f-nondef.d: Adjust expectations.
2021-03-25 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (md_assemble): Widen set of insns to avoid

4
gas/testsuite/gas/i386/avx512f-nondef.d
View File

@ -1,6 +1,6 @@
#as:
#objdump: -dw
#name: i386 AVX512F insns with nondefault values in ignored bits
#name: i386 AVX512F insns with nondefault values in ignored / reserved bits
.*: +file format .*
@ -16,4 +16,6 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: 62 vpmovdb %zmm6,\(bad\)
[ ]*[a-f0-9]+: f2 7e 58 bnd jle (0x7d|7d <.text\+0x7d>)
[ ]*[a-f0-9]+: 31 72 7f xor %esi,0x7f\(%edx\)
[ ]*[a-f0-9]+: 62 f1 7c 88 58 \(bad\)
[ ]*[a-f0-9]+: c3 ret *
#pass

2
gas/testsuite/gas/i386/avx512f-nondef.s
View File

@ -13,3 +13,5 @@
.byte 0x62, 0xf2, 0x7e, 0x48, 0x31, 0x72, 0x7f
# vpmovdb %zmm6, 2032(%rdx) # with set EVEX.B bit - we should get (bad) operand
.byte 0x62, 0xf2, 0x7e, 0x58, 0x31, 0x72, 0x7f
# vaddps xmm0, xmm0, xmm3 # with EVEX.z set
.byte 0x62, 0xf1, 0x7c, 0x88, 0x58, 0xc3

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2021-03-25 Jan Beulich <jbeulich@suse.com>
* i386-dis.c (print_insn): Mark as bad EVEX encodings specifying
zeroing-masking without masking.
2021-03-25 Jan Beulich <jbeulich@suse.com>
* i386-opc.tbl (invlpgb): Fix multi-operand form.

7
opcodes/i386-dis.c
View File

@ -9739,6 +9739,13 @@ print_insn (bfd_vma pc, disassemble_info *info)
return end_codep - priv.the_buffer;
}
/* If EVEX.z is set, there must be an actual mask register in use. */
if (vex.zeroing && vex.mask_register_specifier == 0)
{
(*info->fprintf_func) (info->stream, "(bad)");
return end_codep - priv.the_buffer;
}
switch (dp->prefix_requirement)
{
case PREFIX_DATA: