Go to file
Marek Polacek 69bf1c7d5e c++: Fix ICE with inline variable in template [PR97975]
In this test, we have

  static inline const int c = b;

in a class template, and we call store_init_value as usual.  There, the
value is

  IMPLICIT_CONV_EXPR<const float>(b)

which is is_nondependent_static_init_expression but isn't
is_nondependent_constant_expression (they only differ in STRICT).
We call fold_non_dependent_expr, but that just returns the expression
because it only instantiates is_nondependent_constant_expression
expressions.  Since we're not checking the initializer of a constexpr
variable, we go on to call maybe_constant_init, whereupon we crash
because it tries to evaluate all is_nondependent_static_init_expression
expressions, which our value is, but it still contains a template code.

I think the fix is to call fold_non_dependent_init instead of
maybe_constant_init, and only call fold_non_dependent_expr on the
"this is a constexpr variable" path so as to avoid instantiating twice
in a row.  Outside a template this should also avoid evaluating the
value twice.

gcc/cp/ChangeLog:

	PR c++/97975
	* constexpr.c (fold_non_dependent_init): Add a tree parameter.
	Use it.
	* cp-tree.h (fold_non_dependent_init): Add a tree parameter with
	a default value.
	* typeck2.c (store_init_value): Call fold_non_dependent_expr
	only when checking the initializer for constexpr variables.
	Call fold_non_dependent_init instead of maybe_constant_init.

gcc/testsuite/ChangeLog:

	PR c++/97975
	* g++.dg/cpp1z/inline-var8.C: New test.
2020-12-02 14:36:26 -05:00
config Daily bump. 2020-11-26 00:16:41 +00:00
contrib Daily bump. 2020-12-01 00:16:38 +00:00
fixincludes Daily bump. 2020-11-19 00:16:30 +00:00
gcc c++: Fix ICE with inline variable in template [PR97975] 2020-12-02 14:36:26 -05:00
gnattools
gotools Daily bump. 2020-10-30 00:16:29 +00:00
include Daily bump. 2020-09-25 00:16:27 +00:00
INSTALL
intl intl: Unbreak intl build with bison 3 when no regeneration is needed [PR92008] 2020-04-16 11:55:00 +02:00
libada
libatomic Daily bump. 2020-11-30 00:16:27 +00:00
libbacktrace libbacktrace: correct buffer overflow tests 2020-12-02 11:07:59 -08:00
libcc1 Daily bump. 2020-11-30 00:16:27 +00:00
libcpp Daily bump. 2020-12-02 00:16:41 +00:00
libdecnumber Daily bump. 2020-07-31 00:16:26 +00:00
libffi Daily bump. 2020-11-30 00:16:27 +00:00
libgcc Daily bump. 2020-12-01 00:16:38 +00:00
libgfortran Daily bump. 2020-11-30 00:16:27 +00:00
libgo internal/cpu: don't define CacheLinePadSize for mips64x 2020-11-30 12:24:17 -08:00
libgomp Daily bump. 2020-11-30 00:16:27 +00:00
libhsail-rt Daily bump. 2020-11-30 00:16:27 +00:00
libiberty Daily bump. 2020-11-26 00:16:41 +00:00
libitm Daily bump. 2020-11-30 00:16:27 +00:00
libobjc Daily bump. 2020-11-30 00:16:27 +00:00
liboffloadmic Daily bump. 2020-11-30 00:16:27 +00:00
libphobos Daily bump. 2020-12-01 00:16:38 +00:00
libquadmath Daily bump. 2020-11-30 00:16:27 +00:00
libsanitizer Daily bump. 2020-11-30 00:16:27 +00:00
libssp Daily bump. 2020-11-30 00:16:27 +00:00
libstdc++-v3 libstdc++: Use libatomic for tests on all 32-bit powerpc targets 2020-12-02 16:37:56 +00:00
libvtv Daily bump. 2020-11-30 00:16:27 +00:00
lto-plugin Daily bump. 2020-11-30 00:16:27 +00:00
maintainer-scripts Daily bump. 2020-05-30 00:16:27 +00:00
zlib Daily bump. 2020-11-30 00:16:27 +00:00
.dir-locals.el
.gitattributes
.gitignore Sync .gitignore with binutils-gdb 2020-12-02 11:04:01 -07:00
ABOUT-NLS
ar-lib
ChangeLog Daily bump. 2020-11-30 00:16:27 +00:00
ChangeLog.jit
ChangeLog.tree-ssa
compile
config-ml.in config-ml.in: Suppress output from multi-do recipes 2020-11-09 14:28:37 +00:00
config.guess config.sub, config.guess : Import upstream 2020-11-07. 2020-11-23 19:30:01 +00:00
config.rpath
config.sub config.sub, config.guess : Import upstream 2020-11-07. 2020-11-23 19:30:01 +00:00
configure configure: Support building D front-end on *-*-darwin* 2020-11-29 22:09:42 +01:00
configure.ac configure: Support building D front-end on *-*-darwin* 2020-11-29 22:09:42 +01:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.RUNTIME
depcomp
install-sh
libtool-ldflags
libtool.m4 Fix hppa64-hpux11 build to remove source paths from embedded path. 2020-11-29 20:11:38 +00:00
lt~obsolete.m4
ltgcc.m4
ltmain.sh Do not use HAVE_DOS_BASED_FILE_SYSTEM for Cygwin. 2020-04-17 09:22:51 +02:00
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS MAINTAINERS: Add myself as arc port maintainer 2020-12-02 16:09:21 +02:00
Makefile.def
Makefile.in
Makefile.tpl
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
symlink-tree
test-driver
ylwrap

This directory contains the GNU Compiler Collection (GCC).

The GNU Compiler Collection is free software.  See the files whose
names start with COPYING for copying permission.  The manuals, and
some of the runtime libraries, are under different terms; see the
individual source files for details.

The directory INSTALL contains copies of the installation information
as HTML and plain text.  The source of this information is
gcc/doc/install.texi.  The installation information includes details
of what is included in the GCC sources and what files GCC installs.

See the file gcc/doc/gcc.texi (together with other files that it
includes) for usage and porting information.  An online readable
version of the manual is in the files gcc/doc/gcc.info*.

See http://gcc.gnu.org/bugs/ for how to report bugs usefully.

Copyright years on GCC source files may be listed using range
notation, e.g., 1987-2012, indicating that every year in the range,
inclusive, is a copyrightable year that could otherwise be listed
individually.