MatCat.OpenSource/8sa1-gcc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c/86453 (error: type variant differs by TYPE_PACKED in free_lang_data since r255469)

Browse Source 
2018-07-12  Richard Biener  <rguenther@suse.de>

	PR c/86453
	* c-attribs.c (handle_packed_attribute): Do not build a variant
	type with TYPE_PACKED, instead ignore the attribute if we may
	not apply to the original type.

	* g++.dg/warn/pr86453.C: New testcase.

From-SVN: r262575
This commit is contained in:
Richard Biener 2018-07-12 07:13:36 +00:00 committed by Richard Biener
parent 9e39298905
commit cd0762f3ca
4 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/c-family/ChangeLog
View File

@ -1,3 +1,10 @@
2018-07-12 Richard Biener <rguenther@suse.de>
PR c/86453
* c-attribs.c (handle_packed_attribute): Do not build a variant
type with TYPE_PACKED, instead ignore the attribute if we may
not apply to the original type.
2018-07-10 Jakub Jelinek <jakub@redhat.com>
PR c++/86443

9
gcc/c-family/c-attribs.c
View File

@ -502,8 +502,13 @@ handle_packed_attribute (tree *node, tree name, tree ARG_UNUSED (args),
if (TYPE_P (*node))
{
if (!(flags & (int) ATTR_FLAG_TYPE_IN_PLACE))
*node = build_variant_type_copy (*node);
TYPE_PACKED (*node) = 1;
{
warning (OPT_Wattributes,
"%qE attribute ignored for type %qT", name, *node);
*no_add_attrs = true;
}
else
TYPE_PACKED (*node) = 1;
}
else if (TREE_CODE (*node) == FIELD_DECL)
{

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2018-07-12 Richard Biener <rguenther@suse.de>
PR c/86453
* g++.dg/warn/pr86453.C: New testcase.
2018-07-12 Richard Biener <rguenther@suse.de>
PR middle-end/86479

5
gcc/testsuite/g++.dg/warn/pr86453.C Normal file
View File

@ -0,0 +1,5 @@
// { dg-do compile }
// { dg-additional-options "-flto" { target lto } }
struct X {
int *__attribute__((aligned(2), packed)) a; // { dg-warning "attribute ignored" }
} b;