MatCat.OpenSource/8sa1-gcc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gimple-fold: Recompute ADDR_EXPR flags after folding a TMR [PR98268]

Browse Source 
The gimple verifier picked up that an ADDR_EXPR of a MEM_REF was not
marked TREE_CONSTANT even though the address was in fact invariant.
This came from folding a &TARGET_MEM_REF with constant operands to
a &MEM_REF; &TARGET_MEM_REF is never treated as TREE_CONSTANT
but &MEM_REF can be.

gcc/
	PR tree-optimization/98268
	* gimple-fold.c (maybe_canonicalize_mem_ref_addr): Call
	recompute_tree_invariant_for_addr_expr after successfully
	folding a TARGET_MEM_REF that occurs inside an ADDR_EXPR.

gcc/testsuite/
	PR tree-optimization/98268
	* gcc.target/aarch64/sve/pr98268-1.c: New test.
	* gcc.target/aarch64/sve/pr98268-2.c: Likewise.
This commit is contained in:
Richard Sandiford 2021-03-31 19:34:01 +01:00
parent b5c7accfb5
commit c778968339
3 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/gimple-fold.c
View File

@ -5877,6 +5877,8 @@ maybe_canonicalize_mem_ref_addr (tree *t, bool is_debug = false)
if (tem)
{
*t = tem;
if (TREE_CODE (*orig_t) == ADDR_EXPR)
recompute_tree_invariant_for_addr_expr (*orig_t);
res = true;
}
}

11
gcc/testsuite/gcc.target/aarch64/sve/pr98268-1.c Normal file
View File

@ -0,0 +1,11 @@
/* { dg-do link } */
/* { dg-options "-flto -O -ftree-vectorize --param=aarch64-autovec-preference=3" } */
/* { dg-additional-sources "pr98268-2.c" } */
short d, e;
void f(char, long*);
int main() {
long x;
f(-114, &x);
return d == e;
}

10
gcc/testsuite/gcc.target/aarch64/sve/pr98268-2.c Normal file
View File

@ -0,0 +1,10 @@
/* { dg-do compile } */
/* { dg-options "-O -ftree-vectorize --param=aarch64-autovec-preference=3" } */
extern short d[], e[];
void f(char a, long *b) {
for (int c = 0; c < a - 12; c++) {
d[c] = b[c];
e[c] = 0;
}
}