diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv index 3caa0f8ac10..77a72d40dd0 100644 --- a/libstdc++-v3/include/std/charconv +++ b/libstdc++-v3/include/std/charconv @@ -327,7 +327,10 @@ namespace __detail using _Up = __detail::__unsigned_least_t<_Tp>; _Up __unsigned_val = __value; - if (__value == 0 && __first != __last) + if (__first == __last) [[__unlikely__]] + return { __last, errc::value_too_large }; + + if (__value == 0) { *__first = '0'; return { __first + 1, errc{} }; diff --git a/libstdc++-v3/testsuite/20_util/to_chars/95851.cc b/libstdc++-v3/testsuite/20_util/to_chars/95851.cc new file mode 100644 index 00000000000..5f0daf3b30b --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/to_chars/95851.cc @@ -0,0 +1,36 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do run { target c++14 } } + +#include +#include + +void +test01() +{ + char* p = nullptr; + auto res = std::to_chars(p, p, 0, 2); // PR libstdc++/95851 + VERIFY( res.ptr == p ); + VERIFY( res.ec == std::errc::value_too_large ); +} + +int +main() +{ + test01(); +}