MatCat.OpenSource/8sa1-gcc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tree-ssa-mathopts: Use proper poly_int64 comparison with param_avoid_fma_max_bits [PR 98766]

Browse Source 
We ICE here because we end up comparing a poly_int64 with a scalar using
<= rather than maybe_le.
This patch fixes that in the way rich suggests in the PR.

gcc/ChangeLog:

	PR tree-optimization/98766
	* tree-ssa-math-opts.c (convert_mult_to_fma): Use maybe_le when
	comparing against type size with param_avoid_fma_max_bits.

gcc/testsuite/ChangeLog:

	PR tree-optimization/98766
	* gcc.dg/pr98766.c: New test.
This commit is contained in:
Kyrylo Tkachov 2021-01-21 16:33:49 +00:00
parent eee8ed2f22
commit 9d33785f57
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gcc/testsuite/gcc.dg/pr98766.c Normal file
View File

@ -0,0 +1,12 @@
/* PR tree-optimization/98766. */
/* { dg-do compile } */
/* { dg-options "-O3 --param=avoid-fma-max-bits=8 " } */
/* { dg-additional-options "-march=armv8.2-a+sve" { target aarch64*-*-* } } */
extern int a[];
void c(short *d) {
for (int e = 0; e < 9; e++)
a[e] = d[e] * 2;
}

4
gcc/tree-ssa-math-opts.c
View File

@ -3252,8 +3252,8 @@ convert_mult_to_fma (gimple *mul_stmt, tree op1, tree op2,
bool check_defer
= (state->m_deferring_p
&& (tree_to_shwi (TYPE_SIZE (type))
<= param_avoid_fma_max_bits));
&& maybe_le (tree_to_poly_int64 (TYPE_SIZE (type)),
param_avoid_fma_max_bits));
bool defer = check_defer;
bool seen_negate_p = false;
/* Make sure that the multiplication statement becomes dead after