MatCat.OpenSource/8sa1-gcc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cpplib.c (do_pragma_implementation): Fix off-by-one error truncating a string.

Browse Source 
* cpplib.c (do_pragma_implementation): Fix off-by-one error
	truncating a string.  Don't assume tokens are nul terminated.
	Problem noted by Andreas Jaeger <aj@suse.de>

From-SVN: r32507
This commit is contained in:
Zack Weinberg 2000-03-13 17:25:36 +00:00 committed by Zack Weinberg
parent bc808e0bc5
commit 0e091b520e
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2000-03-13 Zack Weinberg <zack@wolery.cumb.org>
* cpplib.c (do_pragma_implementation): Fix off-by-one error
truncating a string. Don't assume tokens are nul terminated.
Problem noted by Andreas Jaeger <aj@suse.de>
2000-03-13 Jason Merrill <jason@casey.cygnus.com>
* dwarf2out.c (add_name_and_src_coords_attributes): Only add

5
gcc/cpplib.c
View File

@ -1705,11 +1705,12 @@ do_pragma_implementation (pfile)
return 1;
}
/* Trim the leading and trailing quote marks from the string. */
name = pfile->token_buffer + written + 1;
len = strlen (name);
len = CPP_PWRITTEN (pfile) - name;
copy = (U_CHAR *) alloca (len);
memcpy (copy, name, len - 1);
copy[len] = '\0'; /* trim trailing quote */
copy[len - 1] = '\0';
if (cpp_included (pfile, copy))
cpp_warning (pfile,

7
gcc/testsuite/gcc.dg/pr-impl.c Normal file
View File

@ -0,0 +1,7 @@
/* Test warnings generated by #pragma implementation in the wrong place. */
/* { dg-do preprocess } */
#pragma implementation "stdlib.h" /* { dg-bogus "appears after" "stdlib.h" } */
#include <stdlib.h>
#include <stdio.h>
#pragma implementation "stdio.h" /* { dg-warning "appears after" "stdio.h" } */