MatCat.OpenSource/8sa1-gcc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

explow: Fix ICE caused by plus_constant [PR94002]

Browse Source 
The following testcase ICEs in cross to riscv64-linux.  The problem is
that we have a DImode integral constant (that doesn't fit into SImode),
which is pushed into a constant pool and later access just the first half of
it using a MEM.  When plus_constant is called on such a MEM, if the constant
has mode, we verify the mode, but if it doesn't, we don't and ICE later on
when we think the CONST_INT is a valid SImode constant.

2020-03-03  Jakub Jelinek  <jakub@redhat.com>

	PR rtl-optimization/94002
	* explow.c (plus_constant): Punt if cst has VOIDmode and
	get_pool_mode is different from mode.

	* gcc.dg/pr94002.c: New test.
This commit is contained in:
Jakub Jelinek 2020-03-03 10:42:34 +01:00
parent 02ae0e08a9
commit 0ab503d34f
4 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2020-03-03 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/94002
* explow.c (plus_constant): Punt if cst has VOIDmode and
get_pool_mode is different from mode.
2020-03-03 Claudiu Zissulescu <claziss@synopsys.com>
* config/arc/arc.c (leigitimate_small_data_address_p): Check if an

3
gcc/explow.c
View File

@ -128,6 +128,9 @@ plus_constant (machine_mode mode, rtx x, poly_int64 c, bool inplace)
cst = gen_lowpart (mode, cst);
gcc_assert (cst);
}
else if (GET_MODE (cst) == VOIDmode
&& get_pool_mode (XEXP (x, 0)) != mode)
break;
if (GET_MODE (cst) == VOIDmode || GET_MODE (cst) == mode)
{
tem = plus_constant (mode, cst, c);

3
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,8 @@
2020-03-03 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/94002
* gcc.dg/pr94002.c: New test.
PR tree-optimization/93927
* gcc.c-torture/compile/pr93927-1.c: New test.
* gcc.c-torture/compile/pr93927-2.c: New test.

13
gcc/testsuite/gcc.dg/pr94002.c Normal file
View File

@ -0,0 +1,13 @@
/* PR rtl-optimization/94002 */
/* { dg-do compile } */
/* { dg-options "-O1 -fno-tree-dce -fno-tree-reassoc" } */
/* { dg-additional-options "-fPIC" { target fpic } } */
unsigned a, b;
void
foo (void)
{
__builtin_sub_overflow (b, 44852956282LL, &a);
a += ~b;
}