MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gdb: fix nits in previous patches

Browse Source 
I forgot to fix some nits pointed out in review before merging the
"frame inlined in outer frame series", this patch fixes them.

gdb/ChangeLog:

	* frame-unwind.h (frame_prev_register_ftype): Fix adjective
	ordering in comment.
	* frame.c (frame_id_eq): Fix indentation.

gdb/testsuite/ChangeLog:

	* gdb.dwarf2/dw2-reg-undefined.exp: Remove spurious #.

Change-Id: Iaddde9677fc3f68382558d1a16f5a0b4beb78bac
This commit is contained in:
Simon Marchi 2020-08-31 13:31:01 -04:00
parent 22b9b4b05b
commit f3bd50f198
5 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2020-08-31 Simon Marchi <simon.marchi@efficios.com>
* frame-unwind.h (frame_prev_register_ftype): Fix adjective
ordering in comment.
* frame.c (frame_id_eq): Fix indentation.
2020-08-31 Scott Linder <scott@scottlinder.com> 2020-08-31 Scott Linder <scott@scottlinder.com>
Simon Marchi <simon.marchi@efficios.com> Simon Marchi <simon.marchi@efficios.com>

2
gdb/frame-unwind.h
View File

@ -134,7 +134,7 @@ typedef void (frame_this_id_ftype) (struct frame_info *this_frame,
a register in THIS frame, or a non-lvalue. a register in THIS frame, or a non-lvalue.
If the previous frame's register was not saved by THIS_FRAME and is If the previous frame's register was not saved by THIS_FRAME and is
therefore undefined, return a not_lval wholly optimized-out value. therefore undefined, return a wholly optimized-out not_lval value.
THIS_PROLOGUE_CACHE can be used to share any prolog analysis data THIS_PROLOGUE_CACHE can be used to share any prolog analysis data
with the other unwind methods. Memory for that cache should be with the other unwind methods. Memory for that cache should be

2
gdb/frame.c
View File

@ -774,7 +774,7 @@ frame_id_eq (frame_id l, frame_id r)
bool eq; bool eq;
if (l.stack_status == FID_STACK_INVALID if (l.stack_status == FID_STACK_INVALID
|| r.stack_status == FID_STACK_INVALID) || r.stack_status == FID_STACK_INVALID)
/* Like a NaN, if either ID is invalid, the result is false. /* Like a NaN, if either ID is invalid, the result is false.
Note that a frame ID is invalid iff it is the null frame ID. */ Note that a frame ID is invalid iff it is the null frame ID. */
eq = false; eq = false;

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2020-08-31 Simon Marchi <simon.marchi@efficios.com>
* gdb.dwarf2/dw2-reg-undefined.exp: Remove spurious #.
2020-08-31 Simon Marchi <simon.marchi@efficios.com> 2020-08-31 Simon Marchi <simon.marchi@efficios.com>
* gdb.dwarf2/frame-inlined-in-outer-frame.exp: New file. * gdb.dwarf2/frame-inlined-in-outer-frame.exp: New file.

2
gdb/testsuite/gdb.dwarf2/dw2-reg-undefined.exp
View File

@ -76,7 +76,7 @@ for {set f 0} {$f < 3} {incr f} {
} }
# Test that the debug log statement in frame_unwind_register_value produces # Test that the debug log statement in frame_unwind_register_value produces
# "not saved" and not# "optimized out". # "not saved" and not "optimized out".
gdb_test "set debug frame 1" gdb_test "set debug frame 1"
gdb_test {print $rax} {frame_unwind_register_value[^\r\n]+rax[^\r\n]+not saved.*} gdb_test {print $rax} {frame_unwind_register_value[^\r\n]+rax[^\r\n]+not saved.*}
gdb_test "set debug frame 0" gdb_test "set debug frame 0"