MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[GOLD] -Wimplicit-fallthrough warning fixes

Browse Source 
* aarch64.cc: Spell fall through comments as "// Fall through.".
	* arm.cc: Likewise.
	* mips.cc: Likewise.
	* powerpc.cc: Likewise.
	* s390.cc: Likewise.
	* sparc.cc: Likewise.
	* x86_64.cc: Likewise.
	* powerpc.cc (Target_powerpc::Relocate::relocate): Add missing
	fall through comments.
	* sparc.cc: (Target_sparc::Scan::global): Likewise.
	(Target_sparc::Relocate::relocate): Likewise.
	* tilegx.cc (Target_tilegx::Relocate::relocate): Likewise.
	* resolve.cc (symbol_to_bits): Add missing break.
This commit is contained in:
Alan Modra 2016-10-05 15:40:11 +10:30
parent 95e61695c1
commit d8e9025191
10 changed files with 47 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gold/ChangeLog
View File

@ -1,3 +1,19 @@
2016-10-06 Alan Modra <amodra@gmail.com>
* aarch64.cc: Spell fall through comments as "// Fall through.".
* arm.cc: Likewise.
* mips.cc: Likewise.
* powerpc.cc: Likewise.
* s390.cc: Likewise.
* sparc.cc: Likewise.
* x86_64.cc: Likewise.
* powerpc.cc (Target_powerpc::Relocate::relocate): Add missing
fall through comments.
* sparc.cc: (Target_sparc::Scan::global): Likewise.
(Target_sparc::Relocate::relocate): Likewise.
* tilegx.cc (Target_tilegx::Relocate::relocate): Likewise.
* resolve.cc (symbol_to_bits): Add missing break.
2016-09-26 Cary Coutant <ccoutant@gmail.com> 2016-09-26 Cary Coutant <ccoutant@gmail.com>
PR gold/20238 PR gold/20238

4
gold/aarch64.cc
View File

@ -7084,13 +7084,13 @@ Target_aarch64<size, big_endian>::Relocate::relocate(
// Return false to stop further processing this reloc. // Return false to stop further processing this reloc.
return false; return false;
} }
// Fallthrough // Fall through.
case elfcpp::R_AARCH64_JUMP26: case elfcpp::R_AARCH64_JUMP26:
if (Reloc::maybe_apply_stub(r_type, relinfo, rela, view, address, if (Reloc::maybe_apply_stub(r_type, relinfo, rela, view, address,
gsym, psymval, object, gsym, psymval, object,
target->stub_group_size_)) target->stub_group_size_))
break; break;
// Fallthrough // Fall through.
case elfcpp::R_AARCH64_TSTBR14: case elfcpp::R_AARCH64_TSTBR14:
case elfcpp::R_AARCH64_CONDBR19: case elfcpp::R_AARCH64_CONDBR19:
reloc_status = Reloc::template pcrela_general<32>( reloc_status = Reloc::template pcrela_general<32>(

2
gold/arm.cc
View File

@ -12820,7 +12820,7 @@ Target_arm<big_endian>::apply_cortex_a8_workaround(
// branch to the stub. We use the THUMB-2 encoding here. // branch to the stub. We use the THUMB-2 encoding here.
upper_insn = 0xf000U; upper_insn = 0xf000U;
lower_insn = 0xb800U; lower_insn = 0xb800U;
// Fall through // Fall through.
case arm_stub_a8_veneer_b: case arm_stub_a8_veneer_b:
case arm_stub_a8_veneer_bl: case arm_stub_a8_veneer_bl:
case arm_stub_a8_veneer_blx: case arm_stub_a8_veneer_blx:

7
gold/mips.cc
View File

@ -10673,8 +10673,7 @@ Target_mips<size, big_endian>::Scan::local(
// no symbol (e.g. part of a compound relocation). // no symbol (e.g. part of a compound relocation).
if (r_sym == 0) if (r_sym == 0)
break; break;
// Fall through.
// FALLTHROUGH
case elfcpp::R_MIPS16_26: case elfcpp::R_MIPS16_26:
case elfcpp::R_MIPS_26: case elfcpp::R_MIPS_26:
@ -10903,7 +10902,6 @@ Target_mips<size, big_endian>::Scan::global(
// Most static relocations require pointer equality, except // Most static relocations require pointer equality, except
// for branches. // for branches.
mips_sym->set_pointer_equality_needed(); mips_sym->set_pointer_equality_needed();
// Fall through. // Fall through.
case elfcpp::R_MIPS_26: case elfcpp::R_MIPS_26:
@ -11183,8 +11181,7 @@ Target_mips<size, big_endian>::Scan::global(
// and has a special meaning. // and has a special meaning.
if (!mips_obj->is_newabi() && strcmp(gsym->name(), "_gp_disp") == 0) if (!mips_obj->is_newabi() && strcmp(gsym->name(), "_gp_disp") == 0)
break; break;
// Fall through.
// FALLTHROUGH
case elfcpp::R_MIPS16_26: case elfcpp::R_MIPS16_26:
case elfcpp::R_MIPS_26: case elfcpp::R_MIPS_26:

15
gold/powerpc.cc
View File

@ -6092,7 +6092,7 @@ Target_powerpc<size, big_endian>::Scan::global(
ppc_object->set_opd_discard(reloc.get_r_offset()); ppc_object->set_opd_discard(reloc.get_r_offset());
break; break;
} }
// Fall thru // Fall through.
case elfcpp::R_PPC64_UADDR64: case elfcpp::R_PPC64_UADDR64:
case elfcpp::R_POWERPC_ADDR32: case elfcpp::R_POWERPC_ADDR32:
case elfcpp::R_POWERPC_UADDR32: case elfcpp::R_POWERPC_UADDR32:
@ -6199,7 +6199,7 @@ Target_powerpc<size, big_endian>::Scan::global(
|| gsym->is_preemptible()))) || gsym->is_preemptible())))
target->make_plt_entry(symtab, layout, gsym); target->make_plt_entry(symtab, layout, gsym);
} }
// Fall thru // Fall through.
case elfcpp::R_PPC64_REL64: case elfcpp::R_PPC64_REL64:
case elfcpp::R_POWERPC_REL32: case elfcpp::R_POWERPC_REL32:
@ -7589,6 +7589,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size != 64) if (size != 64)
// R_PPC_TLSGD, R_PPC_TLSLD, R_PPC_EMB_RELST_LO, R_PPC_EMB_RELST_HI // R_PPC_TLSGD, R_PPC_TLSLD, R_PPC_EMB_RELST_LO, R_PPC_EMB_RELST_HI
break; break;
// Fall through.
case elfcpp::R_POWERPC_TPREL16: case elfcpp::R_POWERPC_TPREL16:
case elfcpp::R_POWERPC_TPREL16_LO: case elfcpp::R_POWERPC_TPREL16_LO:
case elfcpp::R_POWERPC_TPREL16_HI: case elfcpp::R_POWERPC_TPREL16_HI:
@ -7612,6 +7613,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
// R_PPC_EMB_NADDR32, R_PPC_EMB_NADDR16, R_PPC_EMB_NADDR16_LO // R_PPC_EMB_NADDR32, R_PPC_EMB_NADDR16, R_PPC_EMB_NADDR16_LO
// R_PPC_EMB_NADDR16_HI, R_PPC_EMB_NADDR16_HA, R_PPC_EMB_SDAI16 // R_PPC_EMB_NADDR16_HI, R_PPC_EMB_NADDR16_HA, R_PPC_EMB_SDAI16
break; break;
// Fall through.
case elfcpp::R_POWERPC_DTPREL16: case elfcpp::R_POWERPC_DTPREL16:
case elfcpp::R_POWERPC_DTPREL16_LO: case elfcpp::R_POWERPC_DTPREL16_LO:
case elfcpp::R_POWERPC_DTPREL16_HI: case elfcpp::R_POWERPC_DTPREL16_HI:
@ -7640,6 +7642,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
case elfcpp::R_POWERPC_ADDR14_BRTAKEN: case elfcpp::R_POWERPC_ADDR14_BRTAKEN:
case elfcpp::R_POWERPC_REL14_BRTAKEN: case elfcpp::R_POWERPC_REL14_BRTAKEN:
branch_bit = 1 << 21; branch_bit = 1 << 21;
// Fall through.
case elfcpp::R_POWERPC_ADDR14_BRNTAKEN: case elfcpp::R_POWERPC_ADDR14_BRNTAKEN:
case elfcpp::R_POWERPC_REL14_BRNTAKEN: case elfcpp::R_POWERPC_REL14_BRNTAKEN:
{ {
@ -8038,6 +8041,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_MRKREF, R_PPC_EMB_RELST_LO, R_PPC_EMB_RELST_HA // R_PPC_EMB_MRKREF, R_PPC_EMB_RELST_LO, R_PPC_EMB_RELST_HA
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_POWERPC_ADDR16_HI: case elfcpp::R_POWERPC_ADDR16_HI:
case elfcpp::R_POWERPC_REL16_HI: case elfcpp::R_POWERPC_REL16_HI:
case elfcpp::R_PPC64_TOC16_HI: case elfcpp::R_PPC64_TOC16_HI:
@ -8058,6 +8062,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_RELSEC16, R_PPC_EMB_RELST_HI, R_PPC_EMB_BIT_FLD // R_PPC_EMB_RELSEC16, R_PPC_EMB_RELST_HI, R_PPC_EMB_BIT_FLD
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_POWERPC_ADDR16_HA: case elfcpp::R_POWERPC_ADDR16_HA:
case elfcpp::R_POWERPC_REL16_HA: case elfcpp::R_POWERPC_REL16_HA:
case elfcpp::R_PPC64_TOC16_HA: case elfcpp::R_PPC64_TOC16_HA:
@ -8080,6 +8085,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_NADDR16_LO // R_PPC_EMB_NADDR16_LO
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_PPC64_ADDR16_HIGHER: case elfcpp::R_PPC64_ADDR16_HIGHER:
case elfcpp::R_PPC64_TPREL16_HIGHER: case elfcpp::R_PPC64_TPREL16_HIGHER:
Reloc::addr16_hi2(view, value); Reloc::addr16_hi2(view, value);
@ -8089,6 +8095,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_NADDR16_HI // R_PPC_EMB_NADDR16_HI
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_PPC64_ADDR16_HIGHERA: case elfcpp::R_PPC64_ADDR16_HIGHERA:
case elfcpp::R_PPC64_TPREL16_HIGHERA: case elfcpp::R_PPC64_TPREL16_HIGHERA:
Reloc::addr16_ha2(view, value); Reloc::addr16_ha2(view, value);
@ -8098,6 +8105,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_NADDR16_HA // R_PPC_EMB_NADDR16_HA
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_PPC64_ADDR16_HIGHEST: case elfcpp::R_PPC64_ADDR16_HIGHEST:
case elfcpp::R_PPC64_TPREL16_HIGHEST: case elfcpp::R_PPC64_TPREL16_HIGHEST:
Reloc::addr16_hi3(view, value); Reloc::addr16_hi3(view, value);
@ -8107,6 +8115,7 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_SDAI16 // R_PPC_EMB_SDAI16
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_PPC64_ADDR16_HIGHESTA: case elfcpp::R_PPC64_ADDR16_HIGHESTA:
case elfcpp::R_PPC64_TPREL16_HIGHESTA: case elfcpp::R_PPC64_TPREL16_HIGHESTA:
Reloc::addr16_ha3(view, value); Reloc::addr16_ha3(view, value);
@ -8117,11 +8126,13 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
if (size == 32) if (size == 32)
// R_PPC_EMB_NADDR32, R_PPC_EMB_NADDR16 // R_PPC_EMB_NADDR32, R_PPC_EMB_NADDR16
goto unsupp; goto unsupp;
// Fall through.
case elfcpp::R_PPC64_TPREL16_DS: case elfcpp::R_PPC64_TPREL16_DS:
case elfcpp::R_PPC64_TPREL16_LO_DS: case elfcpp::R_PPC64_TPREL16_LO_DS:
if (size == 32) if (size == 32)
// R_PPC_TLSGD, R_PPC_TLSLD // R_PPC_TLSGD, R_PPC_TLSLD
break; break;
// Fall through.
case elfcpp::R_PPC64_ADDR16_DS: case elfcpp::R_PPC64_ADDR16_DS:
case elfcpp::R_PPC64_ADDR16_LO_DS: case elfcpp::R_PPC64_ADDR16_LO_DS:
case elfcpp::R_PPC64_TOC16_DS: case elfcpp::R_PPC64_TOC16_DS:

1
gold/resolve.cc
View File

@ -193,6 +193,7 @@ symbol_to_bits(elfcpp::STB binding, bool is_dynamic,
// table. // table.
gold_error(_("invalid STB_LOCAL symbol in external symbols")); gold_error(_("invalid STB_LOCAL symbol in external symbols"));
bits = global_flag; bits = global_flag;
break;
default: default:
// Any target which wants to handle STB_LOOS, etc., needs to // Any target which wants to handle STB_LOOS, etc., needs to

8
gold/s390.cc
View File

@ -2555,7 +2555,7 @@ Target_s390<size>::Scan::local(Symbol_table* symtab,
unsupported_reloc_local(object, r_type); unsupported_reloc_local(object, r_type);
} }
} }
// fall through // Fall through.
case elfcpp::R_390_TLS_IEENT: case elfcpp::R_390_TLS_IEENT:
case elfcpp::R_390_TLS_GOTIE12: case elfcpp::R_390_TLS_GOTIE12:
case elfcpp::R_390_TLS_GOTIE20: case elfcpp::R_390_TLS_GOTIE20:
@ -2993,7 +2993,7 @@ Target_s390<size>::Scan::global(Symbol_table* symtab,
unsupported_reloc_global(object, r_type, gsym); unsupported_reloc_global(object, r_type, gsym);
} }
} }
// fall through // Fall through.
case elfcpp::R_390_TLS_IEENT: case elfcpp::R_390_TLS_IEENT:
case elfcpp::R_390_TLS_GOTIE12: case elfcpp::R_390_TLS_GOTIE12:
case elfcpp::R_390_TLS_GOTIE20: case elfcpp::R_390_TLS_GOTIE20:
@ -3241,7 +3241,7 @@ Target_s390<size>::Relocate::relocate(
|| (gsym->is_defined() || (gsym->is_defined()
&& !gsym->is_from_dynobj() && !gsym->is_from_dynobj()
&& !gsym->is_preemptible())); && !gsym->is_preemptible()));
// fallthru // Fall through.
case elfcpp::R_390_8: case elfcpp::R_390_8:
case elfcpp::R_390_12: case elfcpp::R_390_12:
case elfcpp::R_390_16: case elfcpp::R_390_16:
@ -3270,7 +3270,7 @@ Target_s390<size>::Relocate::relocate(
gold_assert(gsym == NULL gold_assert(gsym == NULL
|| gsym->has_plt_offset() || gsym->has_plt_offset()
|| gsym->final_value_is_known()); || gsym->final_value_is_known());
// fallthru // Fall through.
case elfcpp::R_390_GOTOFF64: case elfcpp::R_390_GOTOFF64:
case elfcpp::R_390_GOTOFF32: case elfcpp::R_390_GOTOFF32:
case elfcpp::R_390_GOTOFF16: case elfcpp::R_390_GOTOFF16:

8
gold/sparc.cc
View File

@ -2305,7 +2305,7 @@ Target_sparc<size, big_endian>::Scan::local(
reloc.get_r_addend(), is_ifunc); reloc.get_r_addend(), is_ifunc);
break; break;
} }
/* Fall through. */ // Fall through.
case elfcpp::R_SPARC_HIX22: case elfcpp::R_SPARC_HIX22:
case elfcpp::R_SPARC_LOX10: case elfcpp::R_SPARC_LOX10:
@ -2815,6 +2815,7 @@ Target_sparc<size, big_endian>::Scan::global(
// and code transform the GOT load into an addition. // and code transform the GOT load into an addition.
break; break;
} }
// Fall through.
case elfcpp::R_SPARC_GOT10: case elfcpp::R_SPARC_GOT10:
case elfcpp::R_SPARC_GOT13: case elfcpp::R_SPARC_GOT13:
case elfcpp::R_SPARC_GOT22: case elfcpp::R_SPARC_GOT22:
@ -3354,6 +3355,7 @@ Target_sparc<size, big_endian>::Relocate::relocate(
gdop_valid = true; gdop_valid = true;
break; break;
} }
// Fall through.
case elfcpp::R_SPARC_GOT10: case elfcpp::R_SPARC_GOT10:
case elfcpp::R_SPARC_GOT13: case elfcpp::R_SPARC_GOT13:
case elfcpp::R_SPARC_GOT22: case elfcpp::R_SPARC_GOT22:
@ -3475,7 +3477,7 @@ Target_sparc<size, big_endian>::Relocate::relocate(
Reloc::gdop_lox10(view, got_offset); Reloc::gdop_lox10(view, got_offset);
break; break;
} }
/* Fall through. */ // Fall through.
case elfcpp::R_SPARC_GOT10: case elfcpp::R_SPARC_GOT10:
Reloc::lo10(view, got_offset, addend); Reloc::lo10(view, got_offset, addend);
break; break;
@ -3504,7 +3506,7 @@ Target_sparc<size, big_endian>::Relocate::relocate(
Reloc::gdop_hix22(view, got_offset); Reloc::gdop_hix22(view, got_offset);
break; break;
} }
/* Fall through. */ // Fall through.
case elfcpp::R_SPARC_GOT22: case elfcpp::R_SPARC_GOT22:
Reloc::hi22(view, got_offset, addend); Reloc::hi22(view, got_offset, addend);
break; break;

2
gold/tilegx.cc
View File

@ -4428,6 +4428,7 @@ Target_tilegx<size, big_endian>::Relocate::relocate(
psymval = &symval; psymval = &symval;
always_apply_relocation = true; always_apply_relocation = true;
addend = 0; addend = 0;
// Fall through.
// when under PIC mode, these relocations are deferred to rtld // when under PIC mode, these relocations are deferred to rtld
case elfcpp::R_TILEGX_IMM16_X0_HW0: case elfcpp::R_TILEGX_IMM16_X0_HW0:
@ -4618,6 +4619,7 @@ Target_tilegx<size, big_endian>::Relocate::relocate(
got_type = GOT_TYPE_TLS_OFFSET; got_type = GOT_TYPE_TLS_OFFSET;
have_got_offset = true; have_got_offset = true;
} }
// Fall through.
do_update_value: do_update_value:
if (have_got_offset) { if (have_got_offset) {
if (gsym != NULL) { if (gsym != NULL) {

2
gold/x86_64.cc
View File

@ -2361,7 +2361,7 @@ Target_x86_64<size>::Scan::check_non_pic(Relobj* object, unsigned int r_type,
&& !gsym->is_undefined() && !gsym->is_undefined()
&& !gsym->is_preemptible())) && !gsym->is_preemptible()))
return; return;
/* Fall through. */ // Fall through.
case elfcpp::R_X86_64_32: case elfcpp::R_X86_64_32:
// R_X86_64_32 is OK for x32. // R_X86_64_32 is OK for x32.
if (size == 32 && r_type == elfcpp::R_X86_64_32) if (size == 32 && r_type == elfcpp::R_X86_64_32)