MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[gdb/symtab] Fix duplicate CUs in create_cus_from_debug_names_list

Browse Source 
When running test-case gdb.dwarf2/clang-debug-names.exp, I run into the
following warning:
...
(gdb) file clang-debug-names^M
Reading symbols from clang-debug-names...^M
warning: Section .debug_aranges in clang-debug-names has duplicate \
  debug_info_offset 0xc7, ignoring .debug_aranges.^M
...

This is caused by a missing return in commit 3ee6bb113a "[gdb/symtab] Fix
incomplete CU list assert in .debug_names".

Fix this by adding the missing return, such that we have instead this warning:
...
(gdb) file clang-debug-names^M
Reading symbols from clang-debug-names...^M
warning: Section .debug_aranges in clang-debug-names \
  entry at offset 0 debug_info_offset 0 does not exists, \
  ignoring .debug_aranges.^M
...
which is a known problem filed as PR25969 - "Ignoring .debug_aranges with
clang .debug_names".

Tested on x86_64-linux.

gdb/ChangeLog:

2021-02-05  Tom de Vries  <tdevries@suse.de>

	PR symtab/27307
	* dwarf2/read.c (create_cus_from_debug_names_list): Add missing
	return.

gdb/testsuite/ChangeLog:

2021-02-05  Tom de Vries  <tdevries@suse.de>

	PR symtab/27307
	* gdb.dwarf2/clang-debug-names.exp: Check file command warnings.
This commit is contained in:
Tom de Vries 2021-02-05 09:14:25 +01:00
parent fc9a13fbdd
commit d3b54e63f4
4 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2021-02-05 Tom de Vries <tdevries@suse.de>
PR symtab/27307
* dwarf2/read.c (create_cus_from_debug_names_list): Add missing
return.
2021-02-05 Tom de Vries <tdevries@suse.de>
* dwarf2/read.c (create_cus_from_debug_names_list): Fix indentation.

1
gdb/dwarf2/read.c
View File

@ -5350,6 +5350,7 @@ create_cus_from_debug_names_list (dwarf2_per_bfd *per_bfd,
sect_off, 0);
per_bfd->all_comp_units.push_back (per_cu);
}
return;
}
sect_offset sect_off_prev;

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2021-02-05 Tom de Vries <tdevries@suse.de>
PR symtab/27307
* gdb.dwarf2/clang-debug-names.exp: Check file command warnings.
2021-02-04 Shahab Vahedi <shahab@synopsys.com>
* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.

16
gdb/testsuite/gdb.dwarf2/clang-debug-names.exp
View File

@ -33,6 +33,22 @@ if { [prepare_for_testing "failed to prepare" ${testfile} \
return -1
}
set test "no file command warnings"
if { [regexp "warning: " $gdb_file_cmd_msg] } {
set kfail_re \
[concat \
"warning: Section .debug_aranges in \[^\r\n\]* entry" \
"at offset 0 debug_info_offset 0 does not exists," \
"ignoring \\.debug_aranges\\."]
if { [regexp $kfail_re $gdb_file_cmd_msg] } {
kfail symtab/25969 $test
} else {
fail $test
}
} else {
pass $test
}
set cmd "ptype main"
set pass_re \
[multi_line \