MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[AArch64] Generate DT_TEXTREL for relocation against read-only section

Browse Source 
2015-06-23  Jiong Wang  <jiong.wang@arm.com>

  bfd/
    * elfnn-aarch64.c (aarch64_readonly_dynrelocs): New function.
    (elfNN_aarch64_size_dynamic_sections): Traverse hash table to check
    relocations against read-only sections.

  ld/testsuite/
    * ld-aarch64/dt_textrel.s: New testcase.
    * ld-aarch64/dt_textrel.d: New expectation file.
    * ld-aarch64/aarch64-elf.exp: Run new testcase.
This commit is contained in:
Jiong Wang 2015-06-23 12:12:06 +01:00
parent e5ee3fe285
commit c217058957
6 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2015-06-23 Jiong Wang <jiong.wang@arm.com>
* elfnn-aarch64.c (aarch64_readonly_dynrelocs): New function.
(elfNN_aarch64_size_dynamic_sections): Traverse hash table to check
relocations against read-only sections.
2015-06-18 Nick Clifton <nickc@redhat.com> 2015-06-18 Nick Clifton <nickc@redhat.com>
PR 18481 PR 18481

30
bfd/elfnn-aarch64.c
View File

@ -7545,6 +7545,32 @@ elfNN_aarch64_allocate_local_ifunc_dynrelocs (void **slot, void *inf)
return elfNN_aarch64_allocate_ifunc_dynrelocs (h, inf); return elfNN_aarch64_allocate_ifunc_dynrelocs (h, inf);
} }
/* Find any dynamic relocs that apply to read-only sections. */
static bfd_boolean
aarch64_readonly_dynrelocs (struct elf_link_hash_entry * h, void * inf)
{
struct elf_aarch64_link_hash_entry * eh;
struct elf_dyn_relocs * p;
eh = (struct elf_aarch64_link_hash_entry *) h;
for (p = eh->dyn_relocs; p != NULL; p = p->next)
{
asection *s = p->sec;
if (s != NULL && (s->flags & SEC_READONLY) != 0)
{
struct bfd_link_info *info = (struct bfd_link_info *) inf;
info->flags |= DF_TEXTREL;
/* Not an error, just cut short the traversal. */
return FALSE;
}
}
return TRUE;
}
/* This is the most important function of all . Innocuosly named /* This is the most important function of all . Innocuosly named
though ! */ though ! */
static bfd_boolean static bfd_boolean
@ -7832,6 +7858,10 @@ elfNN_aarch64_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED,
/* If any dynamic relocs apply to a read-only section, /* If any dynamic relocs apply to a read-only section,
then we need a DT_TEXTREL entry. */ then we need a DT_TEXTREL entry. */
if ((info->flags & DF_TEXTREL) == 0)
elf_link_hash_traverse (& htab->root, aarch64_readonly_dynrelocs,
info);
if ((info->flags & DF_TEXTREL) != 0) if ((info->flags & DF_TEXTREL) != 0)
{ {
if (!add_dynamic_entry (DT_TEXTREL, 0)) if (!add_dynamic_entry (DT_TEXTREL, 0))

6
ld/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2015-06-23 Jiong Wang <jiong.wang@arm.com>
* ld-aarch64/dt_textrel.s: New testcase.
* ld-aarch64/dt_textrel.d: New expectation file.
* ld-aarch64/aarch64-elf.exp: Run new testcase.
2015-06-17 Jiong Wang <jiong.wang@arm.com> 2015-06-17 Jiong Wang <jiong.wang@arm.com>
* ld-aarch64/aarch64-elf.exp (aarch64_choose_ilp32_emul): New function. * ld-aarch64/aarch64-elf.exp (aarch64_choose_ilp32_emul): New function.

2
ld/testsuite/ld-aarch64/aarch64-elf.exp
View File

@ -203,6 +203,8 @@ run_dump_test "ifunc-22"
run_dump_test "relasz" run_dump_test "relasz"
run_dump_test "relocs-257-symbolic-func" run_dump_test "relocs-257-symbolic-func"
run_dump_test "dt_textrel"
set aarch64elflinktests { set aarch64elflinktests {
{"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s} {"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s}
{} "copy-reloc-so.so"} {} "copy-reloc-so.so"}

7
ld/testsuite/ld-aarch64/dt_textrel.d Normal file
View File

@ -0,0 +1,7 @@
#source: dt_textrel.s
#ld: -shared
#readelf: -d
#...
.*TEXTREL.*
.*

9
ld/testsuite/ld-aarch64/dt_textrel.s Normal file
View File

@ -0,0 +1,9 @@
.cpu generic+fp+simd
.global p
.comm x,4,4
.section .rodata
.align 3
.type p, %object
.size p, 8
p:
.xword x