MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix gdb.base/charset.exp with Clang

Browse Source 
gdb.base/charset.exp fails to run with Clang, because of:

 gdb compile failed, /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:144:20: warning:
       implicit conversion from 'int' to 'char' changes value from 162 to -94
       [-Wconstant-conversion]
		11, 162, 17);
		    ^~~
 /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:151:16: warning:
       implicit conversion from 'int' to 'char' changes value from 167 to -89
       [-Wconstant-conversion]
		167,
		^~~
 /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:168:16: warning:
       implicit conversion from 'int' to 'char' changes value from 167 to -89
       [-Wconstant-conversion]
		167,
		^~~
 3 warnings generated.

		 === gdb Summary ===

 # of untested testcases         1

Fix it by changing init_string to take unsigned char parameters.

gdb/testsuite/ChangeLog:

	* gdb.base/charset.c (init_string): Change all char parameters to
	unsigned char parameters.
This commit is contained in:
Pedro Alves 2020-07-02 15:54:36 +01:00
parent 2eb8215700
commit bf90c83acc
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-07-03 Pedro Alves <palves@redhat.com>
* gdb.base/charset.c (init_string): Change all char parameters to
unsigned char parameters.
2020-07-03 Pedro Alves <palves@redhat.com>
* gdb.base/call-sc.exp (start_scalars_test): Use

17
gdb/testsuite/gdb.base/charset.c
View File

@ -77,12 +77,21 @@ short short_array[3];
int int_array[3];
long long_array[3];
/* These are unsigned char so we can pass down characters >127 without
explicit casts or warnings. */
void
init_string (char string[],
char x,
char alert, char backspace, char form_feed,
char line_feed, char carriage_return, char horizontal_tab,
char vertical_tab, char cent, char misc_ctrl)
unsigned char x,
unsigned char alert,
unsigned char backspace,
unsigned char form_feed,
unsigned char line_feed,
unsigned char carriage_return,
unsigned char horizontal_tab,
unsigned char vertical_tab,
unsigned char cent,
unsigned char misc_ctrl)
{
int i;