MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replace "if (x) free (x)" with "free (x)", gas

Browse Source 
* atof-generic.c: Replace "if (x) free (x)" with "free (x)"
	throughout.
	* config/obj-elf.c: Likewise.
	* config/tc-aarch64.c: Likewise.
	* config/tc-arm.c: Likewise.
	* config/tc-m68k.c: Likewise.
	* config/tc-nios2.c: Likewise.
	* config/tc-tic30.c: Likewise.
	* ecoff.c: Likewise.
	* read.c: Likewise.
	* stabs.c: Likewise.
	* symbols.c: Likewise.
	* testsuite/gas/all/test-gen.c: Likewise.
This commit is contained in:
Alan Modra 2020-05-20 22:49:01 +09:30
parent 9db70fc365
commit 9fbb53c7c8
13 changed files with 41 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gas/ChangeLog
View File

@ -1,3 +1,19 @@
2020-05-21 Alan Modra <amodra@gmail.com>
* atof-generic.c: Replace "if (x) free (x)" with "free (x)"
throughout.
* config/obj-elf.c: Likewise.
* config/tc-aarch64.c: Likewise.
* config/tc-arm.c: Likewise.
* config/tc-m68k.c: Likewise.
* config/tc-nios2.c: Likewise.
* config/tc-tic30.c: Likewise.
* ecoff.c: Likewise.
* read.c: Likewise.
* stabs.c: Likewise.
* symbols.c: Likewise.
* testsuite/gas/all/test-gen.c: Likewise.
2020-05-20 Nelson Chu <nelson.chu@sifive.com>
* testsuite/gas/riscv/priv-reg-fail-read-only-01.s: Updated.

6
gas/atof-generic.c
View File

@ -611,10 +611,8 @@ atof_generic (/* return pointer to just AFTER number we read. */
/* Assert sign of the number we made is '+'. */
address_of_generic_floating_point_number->sign = digits_sign_char;
if (temporary_binary_low)
free (temporary_binary_low);
if (power_binary_low)
free (power_binary_low);
free (temporary_binary_low);
free (power_binary_low);
free (digits_binary_low);
}
return return_value;

10
gas/config/obj-elf.c
View File

@ -2021,8 +2021,7 @@ elf_copy_symbol_attributes (symbolS *dest, symbolS *src)
}
else
{
if (destelf->size != NULL)
free (destelf->size);
free (destelf->size);
destelf->size = NULL;
}
S_SET_SIZE (dest, S_GET_SIZE (src));
@ -2124,11 +2123,8 @@ obj_elf_size (int ignore ATTRIBUTE_UNUSED)
if (exp.X_op == O_constant)
{
S_SET_SIZE (sym, exp.X_add_number);
if (symbol_get_obj (sym)->size)
{
xfree (symbol_get_obj (sym)->size);
symbol_get_obj (sym)->size = NULL;
}
xfree (symbol_get_obj (sym)->size);
symbol_get_obj (sym)->size = NULL;
}
else
{

6
gas/config/tc-aarch64.c
View File

@ -8269,8 +8269,7 @@ md_apply_fix (fixS * fixP, valueT * valP, segT seg)
/* Free the allocated the struct aarch64_inst.
N.B. currently there are very limited number of fix-up types actually use
this field, so the impact on the performance should be minimal . */
if (fixP->tc_fix_data.inst != NULL)
free (fixP->tc_fix_data.inst);
free (fixP->tc_fix_data.inst);
return;
}
@ -9557,8 +9556,7 @@ aarch64_elf_copy_symbol_attributes (symbolS *dest, symbolS *src)
}
else
{
if (destelf->size != NULL)
free (destelf->size);
free (destelf->size);
destelf->size = NULL;
}
S_SET_SIZE (dest, S_GET_SIZE (src));

9
gas/config/tc-arm.c
View File

@ -2899,8 +2899,7 @@ s_unreq (int a ATTRIBUTE_UNUSED)
hash_delete (arm_reg_hsh, name, FALSE);
free ((char *) reg->name);
if (reg->neon)
free (reg->neon);
free (reg->neon);
free (reg);
/* Also locate the all upper case and all lower case versions.
@ -2915,8 +2914,7 @@ s_unreq (int a ATTRIBUTE_UNUSED)
{
hash_delete (arm_reg_hsh, nbuf, FALSE);
free ((char *) reg->name);
if (reg->neon)
free (reg->neon);
free (reg->neon);
free (reg);
}
@ -2927,8 +2925,7 @@ s_unreq (int a ATTRIBUTE_UNUSED)
{
hash_delete (arm_reg_hsh, nbuf, FALSE);
free ((char *) reg->name);
if (reg->neon)
free (reg->neon);
free (reg->neon);
free (reg);
}

3
gas/config/tc-m68k.c
View File

@ -6135,8 +6135,7 @@ pop_mri_control (void)
n = mri_control_stack;
mri_control_stack = n->outer;
if (n->top != NULL)
free (n->top);
free (n->top);
free (n->next);
free (n->bottom);
free (n);

7
gas/config/tc-nios2.c
View File

@ -3230,11 +3230,8 @@ nios2_insert_arg (char **parsed_args, const char *insert, int num,
static void
nios2_free_arg (char **parsed_args, int num ATTRIBUTE_UNUSED, int start)
{
if (parsed_args[start])
{
free (parsed_args[start]);
parsed_args[start] = NULL;
}
free (parsed_args[start]);
parsed_args[start] = NULL;
}
/* This function swaps the pseudo-op for a real op. */

3
gas/config/tc-tic30.c
View File

@ -1997,8 +1997,7 @@ md_assemble (char *line)
for (i = 0; i < insn.operands; i++)
{
if (insn.operand_type[i]->immediate.label)
free (insn.operand_type[i]->immediate.label);
free (insn.operand_type[i]->immediate.label);
free (insn.operand_type[i]);
}
}

6
gas/ecoff.c
View File

@ -2526,10 +2526,8 @@ ecoff_directive_def (int ignore ATTRIBUTE_UNUSED)
as_warn (_("empty symbol name in .def; ignored"));
else
{
if (coff_sym_name != (char *) NULL)
free (coff_sym_name);
if (coff_tag != (char *) NULL)
free (coff_tag);
free (coff_sym_name);
free (coff_tag);
coff_sym_name = xstrdup (name);
coff_type = type_info_init;

12
gas/read.c
View File

@ -1332,8 +1332,7 @@ read_a_source_file (const char *name)
new_length += 100;
}
if (tmp_buf)
free (tmp_buf);
free (tmp_buf);
/* We've "scrubbed" input to the preferred format. In the
process we may have consumed the whole of the remaining
@ -1801,8 +1800,7 @@ s_comm_internal (int param,
out:
if (flag_mri)
mri_comment_end (stop, stopc);
if (name != NULL)
free (name);
free (name);
return symbolP;
}
@ -1862,8 +1860,7 @@ s_mri_common (int small ATTRIBUTE_UNUSED)
sym = symbol_find_or_make (name);
c = restore_line_pointer (c);
if (alc != NULL)
free (alc);
free (alc);
if (*input_line_pointer != ',')
align = 0;
@ -5814,8 +5811,7 @@ s_incbin (int x ATTRIBUTE_UNUSED)
done:
if (binfile != NULL)
fclose (binfile);
if (path)
free (path);
free (path);
}
/* .include -- include a file at this point. */

3
gas/stabs.c
View File

@ -564,8 +564,7 @@ generate_asm_file (int type, const char *file)
colon (sym);
if (last_file != NULL)
free (last_file);
free (last_file);
last_file = xstrdup (file);
free (buf);

6
gas/symbols.c
View File

@ -923,14 +923,12 @@ symbol_find_noref (const char *name, int noref)
*copy++ = TOUPPER (c);
*copy = '\0';
if (copy2 != NULL)
free (copy2);
free (copy2);
copy = (char *) name;
}
result = symbol_find_exact_noref (name, noref);
if (copy != NULL)
free (copy);
free (copy);
return result;
}

6
gas/testsuite/gas/all/test-gen.c
View File

@ -711,10 +711,8 @@ output_insns (func **insn, FILE *as_in, FILE *dis_out)
for (; part-- > 0;)
{
skip:
if (data[part].as_in)
free (data[part].as_in);
if (data[part].dis_out
&& data[part].dis_out != data[part].as_in)
free (data[part].as_in);
if (data[part].dis_out != data[part].as_in)
free (data[part].dis_out);
}