MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ubsan: xgate: left shift of negative value

Browse Source 
* xgate-dis.c (print_insn): Don't left shift signed value.
	(ripBits): Formatting, use 1u.
This commit is contained in:
Alan Modra 2020-01-11 12:23:47 +10:30
parent aa1f7fb133
commit 7ef412cf72
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2020-01-13 Alan Modra <amodra@gmail.com>
* xgate-dis.c (print_insn): Don't left shift signed value.
(ripBits): Formatting, use 1u.
2020-01-10 Alan Modra <amodra@gmail.com> 2020-01-10 Alan Modra <amodra@gmail.com>
* tilepro-opc.c (parse_insn_tilepro): Make opval unsigned. * tilepro-opc.c (parse_insn_tilepro): Make opval unsigned.

16
opcodes/xgate-dis.c
View File

@ -193,12 +193,12 @@ print_insn (bfd_vma memaddr, struct disassemble_info* info)
relAddr = XGATE_NINE_BITS >> 1; /* Clip sign bit. */ relAddr = XGATE_NINE_BITS >> 1; /* Clip sign bit. */
relAddr = ~relAddr; /* Make signed. */ relAddr = ~relAddr; /* Make signed. */
relAddr |= (raw_code & 0xFF) + 1; /* Apply our value. */ relAddr |= (raw_code & 0xFF) + 1; /* Apply our value. */
relAddr <<= 1; /* Multiply by two as per processor docs. */ relAddr *= 2; /* Multiply by two as per processor docs. */
} }
else else
{ {
relAddr = raw_code & 0xff; relAddr = raw_code & 0xff;
relAddr = (relAddr << 1) + 2; relAddr = relAddr * 2 + 2;
} }
(*info->fprintf_func)(info->stream, " *%d", relAddr); (*info->fprintf_func)(info->stream, " *%d", relAddr);
(*info->fprintf_func)(info->stream, " Abs* 0x"); (*info->fprintf_func)(info->stream, " Abs* 0x");
@ -212,12 +212,12 @@ print_insn (bfd_vma memaddr, struct disassemble_info* info)
relAddr = XGATE_TEN_BITS >> 1; /* Clip sign bit. */ relAddr = XGATE_TEN_BITS >> 1; /* Clip sign bit. */
relAddr = ~relAddr; /* Make signed. */ relAddr = ~relAddr; /* Make signed. */
relAddr |= (raw_code & 0x1FF) + 1; /* Apply our value. */ relAddr |= (raw_code & 0x1FF) + 1; /* Apply our value. */
relAddr <<= 1; /* Multiply by two as per processor docs. */ relAddr *= 2; /* Multiply by two as per processor docs. */
} }
else else
{ {
relAddr = raw_code & 0x1FF; relAddr = raw_code & 0x1FF;
relAddr = (relAddr << 1) + 2; relAddr = relAddr * 2 + 2;
} }
(*info->fprintf_func)(info->stream, " *%d", relAddr); (*info->fprintf_func)(info->stream, " *%d", relAddr);
(*info->fprintf_func)(info->stream, " Abs* 0x"); (*info->fprintf_func)(info->stream, " Abs* 0x");
@ -299,12 +299,12 @@ ripBits (unsigned int *operandBitsRemaining,
unsigned int memory) unsigned int memory)
{ {
unsigned int currentBit; unsigned int currentBit;
int operand; unsigned int operand = 0;
int numBitsFound; int numBitsFound;
for (operand = 0, numBitsFound = 0, currentBit = 1 for (numBitsFound = 0, currentBit = 1u << ((opcodePTR->size * 8) - 1);
<< ((opcodePTR->size * 8) - 1); numBitsFound < numBitsRequested && currentBit != 0;
(numBitsFound < numBitsRequested) && currentBit; currentBit >>= 1) currentBit >>= 1)
{ {
if (currentBit & *operandBitsRemaining) if (currentBit & *operandBitsRemaining)
{ {