MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gdb: move cheap pointer equality check earlier in types_equal

Browse Source 
I noticed that in types equal we start with a cheap pointer equality
check, then resolve typedefs, then do a series of (semi-)expensive
checks, including checking type names, before, finally performing
another pointer equality check.

We should hoist the second pointer equality check to immediately after
we have resolved typedefs.  This would save performing the more
expensive checks.

This isn't going to give any noticable performance improvement, I just
spotted this in passing and figured I might as well commit the fix.

There should be no user visible changes after this commit.

gdb/ChangeLog:

	* gdbtypes.c (types_equal): Move pointer equality check earlier in
	the function.
This commit is contained in:
Andrew Burgess 2021-03-24 17:48:27 +00:00
parent efd86e5b0f
commit 5e18990f1f
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2021-04-07 Andrew Burgess <andrew.burgess@embecosm.com>
* gdbtypes.c (types_equal): Move pointer equality check earlier in
the function.
2021-04-07 Caroline Tice <cmtice@google.com>
* dwarf2/read.c (try_open_dwop_file): Add path for the binary to

8
gdb/gdbtypes.c
View File

@ -4075,6 +4075,10 @@ types_equal (struct type *a, struct type *b)
if (b->code () == TYPE_CODE_TYPEDEF)
b = check_typedef (b);
/* Check if identical after resolving typedefs. */
if (a == b)
return true;
/* If after resolving typedefs a and b are not of the same type
code then they are not equal. */
if (a->code () != b->code ())
@ -4097,10 +4101,6 @@ types_equal (struct type *a, struct type *b)
&& strcmp (a->name (), b->name ()) == 0)
return true;
/* Check if identical after resolving typedefs. */
if (a == b)
return true;
/* Two function types are equal if their argument and return types
are equal. */
if (a->code () == TYPE_CODE_FUNC)