MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make abbrev_table::abbrevs private

Browse Source 
abbrev_table::abbrevs is only access within abbrev_table's methods, so
it can be private.  Add "m_" prefix.

gdb:

2018-01-18  Yao Qi  <yao.qi@linaro.org>

	* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
	m_abbrevs.
	(abbrev_table::add_abbrev): Update.
	(abbrev_table::lookup_abbrev): Update.
This commit is contained in:
Yao Qi 2018-01-18 15:29:31 +00:00
parent d679c21a43
commit 4a17f7688f
2 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2018-01-18 Yao Qi <yao.qi@linaro.org>
* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
m_abbrevs.
(abbrev_table::add_abbrev): Update.
(abbrev_table::lookup_abbrev): Update.
2018-01-18 Yao Qi <yao.qi@linaro.org> 2018-01-18 Yao Qi <yao.qi@linaro.org>
* ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read. * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.

14
gdb/dwarf2read.c
View File

@ -1514,9 +1514,9 @@ struct abbrev_table
explicit abbrev_table (sect_offset off) explicit abbrev_table (sect_offset off)
: sect_off (off) : sect_off (off)
{ {
abbrevs = m_abbrevs =
XOBNEWVEC (&abbrev_obstack, struct abbrev_info *, ABBREV_HASH_SIZE); XOBNEWVEC (&abbrev_obstack, struct abbrev_info *, ABBREV_HASH_SIZE);
memset (abbrevs, 0, ABBREV_HASH_SIZE * sizeof (struct abbrev_info *)); memset (m_abbrevs, 0, ABBREV_HASH_SIZE * sizeof (struct abbrev_info *));
} }
DISABLE_COPY_AND_ASSIGN (abbrev_table); DISABLE_COPY_AND_ASSIGN (abbrev_table);
@ -1541,11 +1541,13 @@ struct abbrev_table
/* Storage for the abbrev table. */ /* Storage for the abbrev table. */
auto_obstack abbrev_obstack; auto_obstack abbrev_obstack;
private:
/* Hash table of abbrevs. /* Hash table of abbrevs.
This is an array of size ABBREV_HASH_SIZE allocated in abbrev_obstack. This is an array of size ABBREV_HASH_SIZE allocated in abbrev_obstack.
It could be statically allocated, but the previous code didn't so we It could be statically allocated, but the previous code didn't so we
don't either. */ don't either. */
struct abbrev_info **abbrevs; struct abbrev_info **m_abbrevs;
}; };
typedef std::unique_ptr<struct abbrev_table> abbrev_table_up; typedef std::unique_ptr<struct abbrev_table> abbrev_table_up;
@ -18011,8 +18013,8 @@ abbrev_table::add_abbrev (unsigned int abbrev_number,
unsigned int hash_number; unsigned int hash_number;
hash_number = abbrev_number % ABBREV_HASH_SIZE; hash_number = abbrev_number % ABBREV_HASH_SIZE;
abbrev->next = abbrevs[hash_number]; abbrev->next = m_abbrevs[hash_number];
abbrevs[hash_number] = abbrev; m_abbrevs[hash_number] = abbrev;
} }
/* Look up an abbrev in the table. /* Look up an abbrev in the table.
@ -18025,7 +18027,7 @@ abbrev_table::lookup_abbrev (unsigned int abbrev_number)
struct abbrev_info *abbrev; struct abbrev_info *abbrev;
hash_number = abbrev_number % ABBREV_HASH_SIZE; hash_number = abbrev_number % ABBREV_HASH_SIZE;
abbrev = abbrevs[hash_number]; abbrev = m_abbrevs[hash_number];
while (abbrev) while (abbrev)
{ {