MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fetch all registers before writing the core register notes.

Browse Source 
Without this, not all registers were present in the core generated by
gcore.  For example, running 'gcore' on a program without examining
the vector registers (SSE or AVX) would store all the vector registers
as zeros because they were not pulled into the regcache.  Running
'info vector' before 'gcore' would store the correct values in the
core since it populated the regcache.  For Linux processes, a similar
operation is achieved by having the thread iterator callback invoke
target_fetch_registers on each thread before its corresponding
register notes are dumped.

gdb/ChangeLog:

	* fbsd-tdep.c (fbsd_make_corefile_notes): Fetch all target registers
	before writing core register notes.
This commit is contained in:
John Baldwin 2015-03-14 13:47:20 -04:00
parent d053f6be55
commit 3ce5b6e25c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2015-03-16 John Baldwin <jhb@FreeBSD.org>
* fbsd-tdep.c (fbsd_make_corefile_notes): Fetch all target registers
before writing core register notes.
2015-03-16 Yuanhui Zhang <asmwarrior@gmail.com> 2015-03-16 Yuanhui Zhang <asmwarrior@gmail.com>
Pedro Alves <palves@redhat.com> Pedro Alves <palves@redhat.com>

3
gdb/fbsd-tdep.c
View File

@ -89,7 +89,7 @@ fbsd_collect_regset_section_cb (const char *sect_name, int size,
static char * static char *
fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size) fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size)
{ {
const struct regcache *regcache = get_current_regcache (); struct regcache *regcache = get_current_regcache ();
char *note_data; char *note_data;
Elf_Internal_Ehdr *i_ehdrp; Elf_Internal_Ehdr *i_ehdrp;
struct fbsd_collect_regset_section_cb_data data; struct fbsd_collect_regset_section_cb_data data;
@ -104,6 +104,7 @@ fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size)
data.obfd = obfd; data.obfd = obfd;
data.note_data = NULL; data.note_data = NULL;
data.note_size = note_size; data.note_size = note_size;
target_fetch_registers (regcache, -1);
gdbarch_iterate_over_regset_sections (gdbarch, gdbarch_iterate_over_regset_sections (gdbarch,
fbsd_collect_regset_section_cb, fbsd_collect_regset_section_cb,
&data, regcache); &data, regcache);