Code cleanup.
	* dummy-frame.c (dummy_frame_unwinder): Remove its static qualifier.
	Rename to dummy_frame_unwind.
	(dummy_frame_unwind): Remove.
	* dummy-frame.h (dummy_frame_unwind): Reference directly the struct.
	* frame-unwind.c (frame_unwind_init): Use address of
	dummy_frame_unwind and inline_frame_unwind.
	* frame.c (create_sentinel_frame): Use address of
	sentinel_frame_unwind.
	* inline-frame.c (inline_frame_unwinder): Rename to
	inline_frame_unwind.
	(inline_frame_unwind): Remove.
	* inline-frame.h (inline_frame_unwind): Reference directly the struct.
	* sentinel-frame.c (sentinel_frame_unwinder): Rename to
	sentinel_frame_unwind.
	(sentinel_frame_unwind): Remove.
	* sentinel-frame.h (sentinel_frame_unwind): Reference directly the
	struct.
This commit is contained in:
Jan Kratochvil 2010-08-11 13:24:32 +00:00
parent 9f9a8002f0
commit 39d7b0e292
9 changed files with 30 additions and 17 deletions

View File

@ -1,3 +1,24 @@
2010-08-11 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup.
* dummy-frame.c (dummy_frame_unwinder): Remove its static qualifier.
Rename to dummy_frame_unwind.
(dummy_frame_unwind): Remove.
* dummy-frame.h (dummy_frame_unwind): Reference directly the struct.
* frame-unwind.c (frame_unwind_init): Use address of
dummy_frame_unwind and inline_frame_unwind.
* frame.c (create_sentinel_frame): Use address of
sentinel_frame_unwind.
* inline-frame.c (inline_frame_unwinder): Rename to
inline_frame_unwind.
(inline_frame_unwind): Remove.
* inline-frame.h (inline_frame_unwind): Reference directly the struct.
* sentinel-frame.c (sentinel_frame_unwinder): Rename to
sentinel_frame_unwind.
(sentinel_frame_unwind): Remove.
* sentinel-frame.h (sentinel_frame_unwind): Reference directly the
struct.
2010-08-11 Jan Kratochvil <jan.kratochvil@redhat.com> 2010-08-11 Jan Kratochvil <jan.kratochvil@redhat.com>
Code cleanup. Code cleanup.

View File

@ -274,7 +274,7 @@ dummy_frame_this_id (struct frame_info *this_frame,
(*this_id) = cache->this_id; (*this_id) = cache->this_id;
} }
static const struct frame_unwind dummy_frame_unwinder = const struct frame_unwind dummy_frame_unwind =
{ {
DUMMY_FRAME, DUMMY_FRAME,
dummy_frame_this_id, dummy_frame_this_id,
@ -283,10 +283,6 @@ static const struct frame_unwind dummy_frame_unwinder =
dummy_frame_sniffer, dummy_frame_sniffer,
}; };
const struct frame_unwind *const dummy_frame_unwind = {
&dummy_frame_unwinder
};
static void static void
fprint_dummy_frames (struct ui_file *file) fprint_dummy_frames (struct ui_file *file)
{ {

View File

@ -56,6 +56,6 @@ extern void dummy_frame_pop (struct frame_id dummy_id);
/* If the PC falls in a dummy frame, return a dummy frame /* If the PC falls in a dummy frame, return a dummy frame
unwinder. */ unwinder. */
extern const struct frame_unwind *const dummy_frame_unwind; extern const struct frame_unwind dummy_frame_unwind;
#endif /* !defined (DUMMY_FRAME_H) */ #endif /* !defined (DUMMY_FRAME_H) */

View File

@ -53,9 +53,9 @@ frame_unwind_init (struct obstack *obstack)
/* Start the table out with a few default sniffers. OSABI code /* Start the table out with a few default sniffers. OSABI code
can't override this. */ can't override this. */
table->list = OBSTACK_ZALLOC (obstack, struct frame_unwind_table_entry); table->list = OBSTACK_ZALLOC (obstack, struct frame_unwind_table_entry);
table->list->unwinder = dummy_frame_unwind; table->list->unwinder = &dummy_frame_unwind;
table->list->next = OBSTACK_ZALLOC (obstack, struct frame_unwind_table_entry); table->list->next = OBSTACK_ZALLOC (obstack, struct frame_unwind_table_entry);
table->list->next->unwinder = inline_frame_unwind; table->list->next->unwinder = &inline_frame_unwind;
/* The insertion point for OSABI sniffers. */ /* The insertion point for OSABI sniffers. */
table->osabi_head = &table->list->next->next; table->osabi_head = &table->list->next->next;
return table; return table;

View File

@ -1100,7 +1100,7 @@ create_sentinel_frame (struct program_space *pspace, struct regcache *regcache)
information, such as the frame's thread will be added. */ information, such as the frame's thread will be added. */
frame->prologue_cache = sentinel_frame_cache (regcache); frame->prologue_cache = sentinel_frame_cache (regcache);
/* For the moment there is only one sentinel frame implementation. */ /* For the moment there is only one sentinel frame implementation. */
frame->unwind = sentinel_frame_unwind; frame->unwind = &sentinel_frame_unwind;
/* Link this frame back to itself. The frame is self referential /* Link this frame back to itself. The frame is self referential
(the unwound PC is the same as the pc), so make it so. */ (the unwound PC is the same as the pc), so make it so. */
frame->next = frame; frame->next = frame;

View File

@ -256,7 +256,7 @@ inline_frame_sniffer (const struct frame_unwind *self,
return 1; return 1;
} }
const struct frame_unwind inline_frame_unwinder = { const struct frame_unwind inline_frame_unwind = {
INLINE_FRAME, INLINE_FRAME,
inline_frame_this_id, inline_frame_this_id,
inline_frame_prev_register, inline_frame_prev_register,
@ -264,8 +264,6 @@ const struct frame_unwind inline_frame_unwinder = {
inline_frame_sniffer inline_frame_sniffer
}; };
const struct frame_unwind *const inline_frame_unwind = &inline_frame_unwinder;
/* Return non-zero if BLOCK, an inlined function block containing PC, /* Return non-zero if BLOCK, an inlined function block containing PC,
has a group of contiguous instructions starting at PC (but not has a group of contiguous instructions starting at PC (but not
before it). */ before it). */

View File

@ -25,7 +25,7 @@ struct frame_unwind;
/* The inline frame unwinder. */ /* The inline frame unwinder. */
extern const struct frame_unwind *const inline_frame_unwind; extern const struct frame_unwind inline_frame_unwind;
/* Skip all inlined functions whose call sites are at the current PC. /* Skip all inlined functions whose call sites are at the current PC.
Frames for the hidden functions will not appear in the backtrace until the Frames for the hidden functions will not appear in the backtrace until the

View File

@ -86,7 +86,7 @@ sentinel_frame_prev_arch (struct frame_info *this_frame,
return get_regcache_arch (cache->regcache); return get_regcache_arch (cache->regcache);
} }
const struct frame_unwind sentinel_frame_unwinder = const struct frame_unwind sentinel_frame_unwind =
{ {
SENTINEL_FRAME, SENTINEL_FRAME,
sentinel_frame_this_id, sentinel_frame_this_id,
@ -96,5 +96,3 @@ const struct frame_unwind sentinel_frame_unwinder =
NULL, NULL,
sentinel_frame_prev_arch, sentinel_frame_prev_arch,
}; };
const struct frame_unwind *const sentinel_frame_unwind = &sentinel_frame_unwinder;

View File

@ -34,6 +34,6 @@ extern void *sentinel_frame_cache (struct regcache *regcache);
/* At present there is only one type of sentinel frame. */ /* At present there is only one type of sentinel frame. */
extern const struct frame_unwind *const sentinel_frame_unwind; extern const struct frame_unwind sentinel_frame_unwind;
#endif /* !defined (SENTINEL_FRAME_H) */ #endif /* !defined (SENTINEL_FRAME_H) */