MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

x86: drop REGNAM_{AL,AX,EAX}

Browse Source 
The former two are unused anyway. And having such constants isn't very
helpful either, when they live in a place where updating the register
table wouldn't even allow noticing the need to adjust these constants.
This commit is contained in:
Jan Beulich 2021-03-30 14:08:48 +02:00
parent 6288d05f11
commit 3468486226
5 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gas/ChangeLog
View File

@ -1,3 +1,11 @@
2021-03-30 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (reg_eax): New.
(md_begin): Initialize reg_eax.
* config/tc-i386-intel.c (i386_intel_simplify_register): Use
reg_eax.
(i386_intel_simplify): Likewise.
2021-03-30 Jan Beulich <jbeulich@suse.com> 2021-03-30 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (reg_st0): New. * config/tc-i386.c (reg_st0): New.

4
gas/config/tc-i386-intel.c
View File

@ -335,7 +335,7 @@ i386_intel_simplify_register (expressionS *e)
else else
{ {
/* esp is invalid as index */ /* esp is invalid as index */
intel_state.index = i386_regtab + REGNAM_EAX + ESP_REG_NUM; intel_state.index = reg_eax + ESP_REG_NUM;
} }
return 2; return 2;
} }
@ -500,7 +500,7 @@ static int i386_intel_simplify (expressionS *e)
break; break;
default: default:
/* esp is invalid as index */ /* esp is invalid as index */
intel_state.index = i386_regtab + REGNAM_EAX + ESP_REG_NUM; intel_state.index = reg_eax + ESP_REG_NUM;
break; break;
} }

8
gas/config/tc-i386.c
View File

@ -214,6 +214,7 @@ static const char *default_arch = DEFAULT_ARCH;
static const reg_entry bad_reg = { "<bad>", OPERAND_TYPE_NONE, 0, 0, static const reg_entry bad_reg = { "<bad>", OPERAND_TYPE_NONE, 0, 0,
{ Dw2Inval, Dw2Inval } }; { Dw2Inval, Dw2Inval } };
static const reg_entry *reg_eax;
static const reg_entry *reg_st0; static const reg_entry *reg_st0;
static const reg_entry *reg_k0; static const reg_entry *reg_k0;
@ -3091,7 +3092,12 @@ md_begin (void)
switch (regtab->reg_type.bitfield.class) switch (regtab->reg_type.bitfield.class)
{ {
case Reg: case Reg:
if (regtab->reg_type.bitfield.tbyte) if (regtab->reg_type.bitfield.dword)
{
if (regtab->reg_type.bitfield.instance == Accum)
reg_eax = regtab;
}
else if (regtab->reg_type.bitfield.tbyte)
{ {
/* There's no point inserting st(<N>) in the hash table, as /* There's no point inserting st(<N>) in the hash table, as
parentheses aren't included in register_chars[] anyway. */ parentheses aren't included in register_chars[] anyway. */

4
opcodes/ChangeLog
View File

@ -1,3 +1,7 @@
2021-03-30 Jan Beulich <jbeulich@suse.com>
* i386-opc.h (REGNAM_AL, REGNAM_AX, REGNAM_EAX): Delete.
2021-03-30 Jan Beulich <jbeulich@suse.com> 2021-03-30 Jan Beulich <jbeulich@suse.com>
* i386-opc.h (REGNAM_AL, REGNAM_AX, REGNAM_EAX): Adjust values. * i386-opc.h (REGNAM_AL, REGNAM_AX, REGNAM_EAX): Adjust values.

5
opcodes/i386-opc.h
View File

@ -990,11 +990,6 @@ typedef struct
} }
reg_entry; reg_entry;
/* Entries in i386_regtab. */
#define REGNAM_AL 0
#define REGNAM_AX 24
#define REGNAM_EAX 40
extern const reg_entry i386_regtab[]; extern const reg_entry i386_regtab[];
extern const unsigned int i386_regtab_size; extern const unsigned int i386_regtab_size;