MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* dwarf2read.c (init_cutu_and_read_dies_no_follow): Fix comments.

Browse Source 
Remove argument abbrev_section.  All callers updated.
This commit is contained in:
Doug Evans 2014-03-27 12:03:34 -07:00
parent 1dbab08b0e
commit 33e8078637
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2014-03-27 Doug Evans <dje@google.com>
* dwarf2read.c (init_cutu_and_read_dies_no_follow): Fix comments.
Remove argument abbrev_section. All callers updated.
2014-03-27 Doug Evans <dje@google.com> 2014-03-27 Doug Evans <dje@google.com>
* dwarf2read.c (struct dwarf2_cu): Improve comments for members * dwarf2read.c (struct dwarf2_cu): Improve comments for members

22
gdb/dwarf2read.c
View File

@ -5515,10 +5515,9 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
do_cleanups (cleanups); do_cleanups (cleanups);
} }
/* Read CU/TU THIS_CU in section SECTION, /* Read CU/TU THIS_CU but do not follow DW_AT_GNU_dwo_name if present.
but do not follow DW_AT_GNU_dwo_name if present. DWO_FILE, if non-NULL, is the DWO file to read (the caller is assumed
DWOP_FILE, if non-NULL, is the DWO/DWP file to read (the caller is assumed to have already done the lookup to find the DWO file).
to have already done the lookup to find the DWO/DWP file).
The caller is required to fill in THIS_CU->section, THIS_CU->offset, and The caller is required to fill in THIS_CU->section, THIS_CU->offset, and
THIS_CU->is_debug_types, but nothing else. THIS_CU->is_debug_types, but nothing else.
@ -5534,7 +5533,6 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
static void static void
init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu, init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
struct dwarf2_section_info *abbrev_section,
struct dwo_file *dwo_file, struct dwo_file *dwo_file,
die_reader_func_ftype *die_reader_func, die_reader_func_ftype *die_reader_func,
void *data) void *data)
@ -5542,6 +5540,7 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
struct objfile *objfile = dwarf2_per_objfile->objfile; struct objfile *objfile = dwarf2_per_objfile->objfile;
struct dwarf2_section_info *section = this_cu->section; struct dwarf2_section_info *section = this_cu->section;
bfd *abfd = get_section_bfd_owner (section); bfd *abfd = get_section_bfd_owner (section);
struct dwarf2_section_info *abbrev_section;
struct dwarf2_cu cu; struct dwarf2_cu cu;
const gdb_byte *begin_info_ptr, *info_ptr; const gdb_byte *begin_info_ptr, *info_ptr;
struct die_reader_specs reader; struct die_reader_specs reader;
@ -5556,6 +5555,10 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
gdb_assert (this_cu->cu == NULL); gdb_assert (this_cu->cu == NULL);
abbrev_section = (dwo_file != NULL
? &dwo_file->sections.abbrev
: get_abbrev_section_for_cu (this_cu));
/* This is cheap if the section is already read in. */ /* This is cheap if the section is already read in. */
dwarf2_read_section (objfile, section); dwarf2_read_section (objfile, section);
@ -5603,10 +5606,7 @@ init_cutu_and_read_dies_simple (struct dwarf2_per_cu_data *this_cu,
die_reader_func_ftype *die_reader_func, die_reader_func_ftype *die_reader_func,
void *data) void *data)
{ {
init_cutu_and_read_dies_no_follow (this_cu, init_cutu_and_read_dies_no_follow (this_cu, NULL, die_reader_func, data);
get_abbrev_section_for_cu (this_cu),
NULL,
die_reader_func, data);
} }
/* Type Unit Groups. /* Type Unit Groups.
@ -9326,9 +9326,7 @@ create_dwo_cu (struct dwo_file *dwo_file)
per_cu.offset.sect_off = info_ptr - section->buffer; per_cu.offset.sect_off = info_ptr - section->buffer;
per_cu.section = section; per_cu.section = section;
init_cutu_and_read_dies_no_follow (&per_cu, init_cutu_and_read_dies_no_follow (&per_cu, dwo_file,
&dwo_file->sections.abbrev,
dwo_file,
create_dwo_cu_reader, create_dwo_cu_reader,
&create_dwo_cu_data); &create_dwo_cu_data);