MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dtrace-probe: Put semicolon after while on its own line

Browse Source 
clang shows this warning.

  /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body]
            while (*p++ != '\0' && p - strtab < strtab_size);
                                                            ^
  /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning

Putting the semicolon on its own line is not a big sacrifice to get rid of this
warning.  I think it's also useful to keep this, because it can catch errors
like this:

  while (something);
    {
      ...
    }

although gcc would warn about it in a different way (misleading indentation).

This warning is already discussed here in the GCC bugzilla:

  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184

gdb/ChangeLog:

	* dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
	its own line.
This commit is contained in:
Simon Marchi 2017-06-25 12:49:19 +02:00
parent f076f0349c
commit 07809eafc9
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-06-25 Simon Marchi <simon.marchi@ericsson.com>
* dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
its own line.
2017-06-25 Simon Marchi <simon.marchi@ericsson.com>
* nat/x86-dregs.c (x86_show_dr): Print registers one per line.

3
gdb/dtrace-probe.c
View File

@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile,
arg.type_str = xstrdup (p);
/* Use strtab_size as a sentinel. */
while (*p++ != '\0' && p - strtab < strtab_size);
while (*p++ != '\0' && p - strtab < strtab_size)
;
/* Try to parse a type expression from the type string. If
this does not work then we set the type to `long